Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Download Progress Bar #17

Open
blueworrybear opened this issue Aug 26, 2020 · 1 comment
Open

Add Download Progress Bar #17

blueworrybear opened this issue Aug 26, 2020 · 1 comment

Comments

@blueworrybear
Copy link

Hi, I would like to add a download progress bar while installation.

It's because current version will display Your package has been installed! even if the package is still downloading.
It will look like the installation is success but the npm install not finished.

For example:

blueworrybear@LAPTOP-0K8IJ0NA:~/projects/covergates-node$ npm install .

> [email protected] postinstall /home/blueworrybear/projects/covergates-node
> node ./install.js

Downloading release https://github.com/covergates/covergates/releases/download/v0.1.6/covergates-v0.1.6-linux-amd64.tar.gz
covergates has been installed!
^C
blueworrybear@LAPTOP-0K8IJ0NA:~/projects/covergates-node$ 

I have make a code change, which could be referred here: add download progress bar
With the update, the stdout will look like:

blueworrybear@LAPTOP-0K8IJ0NA:~/projects/covergates-node$ npm install .

> [email protected] postinstall /home/blueworrybear/projects/covergates-node
> node ./install.js

Downloading release from https://github.com/covergates/covergates/releases/download/v0.1.6/covergates-v0.1.6-linux-amd64.tar.gz
covergates in now installing
  downloading [====================] 723152/bps 100% 0.0s


covergates has been installed!
npm WARN [email protected] requires a peer of prettier@>=1.13.0 but none is installed. You must install peer dependencies yourself.

audited 138 packages in 45.738s

10 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

I love this project, it's very useful! So please consider this idea. I will make a PR if you agree.

@EverlastingBugstopper
Copy link
Contributor

change looks good! will have to talk to @ispivey about PRs to this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants