Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with resource mv in terraform, moving to new naming convention for workers resources #3635

Closed
3 tasks done
EdsonLuisVieira opened this issue Aug 13, 2024 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@EdsonLuisVieira
Copy link

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.5.5
on darwin_amd64
+ provider registry.terraform.io/cloudflare/cloudflare v4.39.0

Affected resource(s)

cloudflare_worker_route --> cloudflare_workers_route
cloudflare_worker_script --> cloudflare_workers_script

Terraform configuration files

When changing the resources that are going to be deprecated from version 4.38.0 to 4.39.0 I see the output that the resources are going to be recreated, something that I don't want to happen, so I try to make the move and get an error that this is not possible, I would like an option where to update to the new version it is not necessary to delete the existing resources.

Link to debug output

https://gist.github.com/EdsonLuisVieira/db06077d60a1910ea1c1722a15c579e5

Panic output

No response

Expected output

moved successful or the name change does not generate a delete recreate

Actual output

│ Error: Invalid state move request

│ Cannot move module.cloudflare_resources["0"].cloudflare_worker_route.route
│ to module.cloudflare_resources["0"].cloudflare_workers_route.route:
│ resource types don't match.

Steps to reproduce

Test change version and resource name

  1. change version 4.38.0 to 4.39.0
  2. update resources name cloudflare_worker_script to cloudflare_workers_script and cloudflare_worker_route to cloudflare_workers_route
  3. output show destroy and recreate

Test move

  1. change version 4.38.0 to 4.39.0
  2. update resources name cloudflare_worker_script to cloudflare_workers_script and cloudflare_worker_route to cloudflare_workers_route
  3. move resources
    4.terragrunt state mv 'module.cloudflare_resources["0"].cloudflare_worker_route.route[0]' 'module.cloudflare_resources["0"].cloudflare_workers_route.route[0]'

Additional factoids

No response

References

No response

@EdsonLuisVieira EdsonLuisVieira added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 13, 2024
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 13, 2024
@peikk0
Copy link

peikk0 commented Aug 22, 2024

You need to remove and import them back instead:

removed {
  from = module.cloudflare_resources["0"].cloudflare_worker_route.route
  lifecycle { destroy = false }
}

import {
 id = "<account-id>/<route-id>"
 to = module.cloudflare_resources["0"].cloudflare_workers_route.route[0]
}

Copy link
Contributor

Marking this issue as stale due to 30 days of inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
@mabed-fr
Copy link

mabed-fr commented Nov 4, 2024

Hello,

Route workers are not available in v5?

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants