Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.10.0 fails when getting ${{ steps.deploy.outputs.deployment-url }} #307

Open
cawauchi6204 opened this issue Oct 24, 2024 · 2 comments

Comments

@cawauchi6204
Copy link

Description

I've started seeing the following failures with the latest release:

- name: Deploy
  id: deploy
  uses: cloudflare/wrangler-action@v3
  with:
    apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
    accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
    command: pages deploy --project-name=example --branch=${{ inputs.branch-name }}

- name: print deployment-url
  env:
    DEPLOYMENT_URL: ${{ steps.deploy.outputs.deployment-url }}
  run: echo $DEPLOYMENT_URL

output

and I pined

  uses: cloudflare/[email protected]

and it was success.

@tsukimizake
Copy link

On pages publish and pages deploy, deployment-url seems to be renamed to url.
https://github.com/cloudflare/wrangler-action/pull/303/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R369

@tiangolo
Copy link

tiangolo commented Oct 24, 2024

I made an initial PR to handle it here: #308, but it doesn't include tests, maybe they would want to add them or use the initial idea to fix it in a different way. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants