Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthToken.kt various warnings #110

Open
TomerPacific opened this issue Oct 14, 2024 · 3 comments
Open

AuthToken.kt various warnings #110

TomerPacific opened this issue Oct 14, 2024 · 3 comments

Comments

@TomerPacific
Copy link
Contributor

When inspecting the AuthToken.kt file, there are 7 warnings there:

  1. Private property name 'UNSAFE_URL_CHARS_PATTERN' should not contain underscores in the middle or the end (line 24)
  2. Unchecked cast: Any? to ArrayList (line 47)
  3. 'acl: String?' is deprecated. This parameter will be removed in the next major version, use acls instead (lines 75, 76, 82, 124 and 139)

Relates to #107
@wissam-khalili
Copy link

@adimiz1 - Can you please review this one?
Thanks!

@TomerPacific
Copy link
Contributor Author

@wissam-khalili - Since the deprecation warning is internal, do we want to remove the parameter?

@wissam-khalili
Copy link

@adimiz1 - Can you review @TomerPacific question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomerPacific @wissam-khalili