Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK not dropping exisitng image/upload in the URL #99

Open
ananthrajsingh opened this issue Apr 1, 2024 · 6 comments
Open

SDK not dropping exisitng image/upload in the URL #99

ananthrajsingh opened this issue Apr 1, 2024 · 6 comments
Assignees

Comments

@ananthrajsingh
Copy link

ananthrajsingh commented Apr 1, 2024

When the URL to be processed contains image/upload, that should be dropped from path to remove duplicacy.

For example:
This URL
https://something.furlenco.com/image/upload/v1/bucket/products/5900/hero/1702711218.jpg

should be processed to
https://res.cloudinary.com/key/image/upload/dpr_1.0,named_trans,w_500/v1/bucket/products/5900/hero/1702711218.jpg? (iOS SDK does this transformation, removing image/upload from the end path)

But Kotlin SDK sends out this
https://res.cloudinary.com/key/image/upload/named_trans/c_scale,w_500/dpr_1.0/image/upload/v1/bucket/products/5900/hero/1702711218.jpg? (notice a couple of image/upload)

Checking the iOS SDK, it does have logic to find and drop things like image/upload..

Screenshot 2024-03-29 at 4 51 37 PM

Can you help me understand why is Kotlin SDK not equipped with a similar logic? Due to this we are not able use the same URL format for both Android and iOS clients.

@adimiz1 adimiz1 self-assigned this Apr 1, 2024
@wissam-khalili
Copy link

Hi @ananthrajsingh,

You are right, the current functionality does not exist in the Kotlin SDK, I have opened an internal issue to fix it.
For now, you can pass on the public id (with the folders in the path).
We will keep you posted when the fix will be released.

Regards,
Wissam

@ananthrajsingh
Copy link
Author

Sure, thanks for acknowledgement and starting the work towards it. Please do let me know once resolved.

@ananthrajsingh
Copy link
Author

@wissam-khalili @adimiz1 Any update on this?

@tommyg-cld
Copy link

@ananthrajsingh this is still in our backlog but no ETA at the moment. We will update you as soon as we have a fix.

@tommyg-cld
Copy link

@ananthrajsingh this is fixed so please update to the latest version and let us know if you still have issues.

@ananthrajsingh
Copy link
Author

Thanks @tommyg-cld for notifying. Will schedule an upgrade with the team and close the ticket if resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants