Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows burn does not work on powershell or cmd #74

Open
jpfleischer opened this issue May 28, 2022 · 2 comments
Open

windows burn does not work on powershell or cmd #74

jpfleischer opened this issue May 28, 2022 · 2 comments
Assignees
Labels
5 priority five (lowest) bug Something isn't working easy

Comments

@jpfleischer
Copy link
Member

jpfleischer commented May 28, 2022

line 498 the shell.execute doesnt work on powershell or cmd. only git bash works
windowssdcard.py

        try:
            lines = Shell.bash("cat /proc/partitions")
        except subprocess.CalledProcessError as e:
            print(str(e.output))
        print(lines)
@jpfleischer jpfleischer added wontfix This will not be worked on 5 priority five (lowest) labels May 28, 2022
@laszewsk
Copy link
Member

laszewsk commented May 28, 2022

we shoudl just replace with python readfile

form cloudmesh.common.util import readfile
try
   lines = readfile("/proc/partitions")
except Exeption as e:
   print(e)
   Console.error("issue reading /proc/partitions)

However i do not know if /pro/partitions even exists on powershell or windows. Please develop pytest so its easy to run on the different osses CMD, powershel, git bash, mac, linus

@laszewsk laszewsk added bug Something isn't working easy and removed wontfix This will not be worked on labels May 28, 2022
@jpfleischer
Copy link
Member Author

for cms burn to work:
add test for cms burn if you are on windows and git bash is not installed, spit out a warning and interrupt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 priority five (lowest) bug Something isn't working easy
Projects
None yet
Development

No branches or pull requests

2 participants