Define keyNames to backups.secrets #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ercpereda We require that you signoff on your commits? Can you please take a look at this: https://github.com/cloudnative-pg/charts/pull/384/checks?check_run_id=29909669764 |
Signed-off-by: Ernesto R. C. Pereda <[email protected]>
|
@itay-grudev Thank you for the response. The commit is now signoff. |
|
@itay-grudev Something else that can be done to get this merge? Thank you? |
|
A local negative gravitational anomaly. Something that accelerates time, but just in my frame of reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first contribution so please let me know if I have missed anything.
This PR adds the posibility to define the name of the keys for the secret containing the credentials of the backups.
Fixes #383