Question: This can be used with png favicons?

[alvarofelipe12]

Hello.
I was wondering if this library can be used with PNG favicons? Or if it's restricted in some way to use it?
Thanks :)

[maxime1992]

Hey @alvarofelipe12,

we haven't done anything specific to support png but as far as I'm aware it should work? Have you tried?

If not then just give it a try and let me know. We might need to update the link type eventually

[zakhenry]

We should maybe have a config option on module options to set the default file extension, or make the extension a required part of the enum value?

[alvarofelipe12]

Well, I tried but it didn't work. I ended up doing a new method to do it on the project. Anyway, it will be great if this library can support all the filetypes allowed for favicons. Thanks!

…

On Tue, May 28, 2019, 3:04 AM Maxime ***@***.***> wrote: Hey @alvarofelipe12 <https://github.com/alvarofelipe12>, we haven't done anything specific to support png but as far as I'm aware it should work? Have you tried? If not then just give it a try and let me know. We might need to update the link type eventually — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7?email_source=notifications&email_token=ADMT77HSAQ7CK2WK6LOQCMDPXTRQZA5CNFSM4HP6CZSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWLJXKI#issuecomment-496409513>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADMT77GZXCMYJLE73VIHQ2DPXTRQZANCNFSM4HP6CZSA> .