Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms should be pristine and untouched after creation #154

Open
zakhenry opened this issue Mar 3, 2020 · 2 comments
Open

Forms should be pristine and untouched after creation #154

zakhenry opened this issue Mar 3, 2020 · 2 comments
Labels
effort-2: hours Will only take a few hours to fix/create type: bug/fix This is a bug or at least needs a fix workaround-2: non obvious Non obvious workaround

Comments

@zakhenry
Copy link
Contributor

zakhenry commented Mar 3, 2020

Failing test raised #153

Basically when loading a new form and filling it with data for the first time the form should be both pristine and untouched. This generally works with some exceptional cases that I haven't quite pinned down yet (something to do with sub-forms emitInitialValueOnInit value)
@zakhenry zakhenry added effort-2: hours Will only take a few hours to fix/create type: bug/fix This is a bug or at least needs a fix workaround-2: non obvious Non obvious workaround labels Mar 3, 2020
@zakhenry
Copy link
Contributor Author

zakhenry commented Mar 3, 2020

There is a workaround - for the offending sub-forms, set public emitInitialValueOnInit = false, however this solution is not tenable for some scenarios like polymorphic controls.

@zakhenry
Copy link
Contributor Author

only though of how to solve would be to change the default to public emitInitialValueOnInit = false. not sure how to solve the polymorphic case though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-2: hours Will only take a few hours to fix/create type: bug/fix This is a bug or at least needs a fix workaround-2: non obvious Non obvious workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zakhenry