You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.
The text was updated successfully, but these errors were encountered:
Bug regarding redundant invalid/valid props, as in the Switch component. See screenshot: Option can be invalid and valid at the same time with two icons and a green boarder. Suggestion described here.
If error and loading are true, loading takes precedence. I think error should precedence? However, a better solution here would be to introduce a variant prop (as suggested for the Switch component here) so only one such state could be true at any one time and therefore, we wouldn't need to do extensive checks.
When NativeSelectionGroup is disabled, the dropdown doesn't have any default value. It only appears on click.
UX Improvements
Disable dropdown if all dropdown groups/options disabled? See example: all options disabled once you click, but dropdown is still enabled with "Option 1".
I'd like to further understand the usefulness of the states for the dropdown. At the very least, it would be helpful to have messages explaining why some options have these states, especially in the case of error.
Task Description
We need to convert NativeSelect(All related) and all related components from @cloudoperators/juno-ui-components to TypeScript
List of potential dependencies
Sub-tasks
Related Issues
Additional Context
Please check this online codemode editor to change the PropTypes to a proper Ts interfaces
https://github.com/mskelton/ratchet
Online editor: https://ratchet.mskelton.dev/
We need to be pretty concious about migration to ts cause it could create a potential breaking changes. Also if there will be too much changes at once maybe consider to split up the task again. Also some dependencies could be hidden and only discovered while executing the migration, could also lead to potential reconsidering the order of task execution.
The text was updated successfully, but these errors were encountered: