Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zonal shift configuration #243

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

z0rc
Copy link
Contributor

@z0rc z0rc commented Oct 31, 2024

what

Add support of zonal shift config for the cluster. Closes #242

why

See linked ticket.

references

See linked ticket.

additional info

<br> to <br/> changes are caused by new version of terraform-docs and are intended, see terraform-docs/terraform-docs#787

@z0rc z0rc requested review from a team as code owners October 31, 2024 20:02
@z0rc z0rc requested review from Gowiem and gberenice October 31, 2024 20:02
@mergify mergify bot added the triage Needs triage label Oct 31, 2024
@gberenice
Copy link

/terratest

@z0rc
Copy link
Contributor Author

z0rc commented Nov 1, 2024

Thanks, I'll check test failures.

@gberenice
Copy link

@z0rc, thanks for your contribution!
Currently, tests are failing:

 Error:      	Received unexpected error:
      FatalError{Underlying: error while running command: exit status 1; ╷
      │ Error: Unsupported argument
      │ 
      │   on ../../main.tf line 66, in resource "aws_eks_cluster" "default":
      │   66:   zonal_shift_config            = var.zonal_shift_config
      │ 
      │ An argument named "zonal_shift_config" is not expected here. Did you mean
      │ to define a block of type "zonal_shift_config"?
      ╵}

could you please update zonal_shift_config to use a block? see access_config as an example.

@z0rc
Copy link
Contributor Author

z0rc commented Nov 1, 2024

@gberenice I decided to use dynamic block here, as it optional in provider and most configurations won't have it set.

@gberenice
Copy link

/terratest

@z0rc
Copy link
Contributor Author

z0rc commented Nov 1, 2024

Okay, almost there. Need a bit more time.

@z0rc
Copy link
Contributor Author

z0rc commented Nov 1, 2024

@gberenice ready to test.

@gberenice
Copy link

/terratest

Copy link

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @z0rc!

@gberenice gberenice merged commit cf32252 into cloudposse:main Nov 1, 2024
16 checks passed
@mergify mergify bot removed the triage Needs triage label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

These changes were released in v4.4.1.

@z0rc z0rc deleted the zonal-shift branch November 1, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSA: EKS ARC zonal shift
2 participants