Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Oldest Replication Slot Lag RDS alarm #49

Closed
wants to merge 2 commits into from
Closed

Add Oldest Replication Slot Lag RDS alarm #49

wants to merge 2 commits into from

Conversation

dazza-codes
Copy link

@dazza-codes dazza-codes commented Mar 2, 2023 •
edited
Loading

Fix #48

This pulls in a patch from @mgeist on https://github.com/BetterWorks/terraform-aws-rds-cloudwatch-sns-alarms

Steps to replicate this patch:

git clone [email protected]:dazza-codes/terraform-aws-rds-cloudwatch-sns-alarms.git 
cd terraform-aws-rds-cloudwatch-sns-alarms
git remote add betterworks [email protected]:BetterWorks/terraform-aws-rds-cloudwatch-sns-alarms.git
git fetch betterworks 
git cherry-pick 3b67e0959695533a28a79242c2d9bc5d09b24394
git checkout -b add-OldestReplicationSlotLag
git push --set-upstream origin add-OldestReplicationSlotLag

There are no format changes added by this PR (other than those already in the BetterWorks commit).

❯ terraform fmt *.tf

This PR does update the BetterWorks patch for the latest cloudposse module details. When consuming the PR branch as a module, the terraform validate is working, e.g. a consumer can try:

# https://github.com/cloudposse/terraform-aws-rds-cloudwatch-sns-alarms/issues/48
# https://github.com/cloudposse/terraform-aws-rds-cloudwatch-sns-alarms/pull/49
module "rds_alarms" {
  source         = "git::https://github.com/dazza-codes/terraform-aws-rds-cloudwatch-sns-alarms.git?ref=add-OldestReplicationSlotLag"
  db_instance_id = aws_db_instance.rds.id
  namespace      = var.namespace
  name           = var.project_name
  stage          = var.stage
}

@dazza-codes dazza-codes requested review from a team as code owners March 2, 2023 16:35
@dazza-codes dazza-codes requested review from jamengual and joe-niland and removed request for a team March 2, 2023 16:35
@dazza-codes dazza-codes marked this pull request as draft March 2, 2023 16:56
@dazza-codes dazza-codes marked this pull request as ready for review March 6, 2023 19:45
@dazza-codes
Copy link
Author

The CI workflow includes pushing changes to my fork and that will fail because it doesn't have permission to do that.

Changes detected. Pushing to the PR branch
+ git config --global user.email [email protected]
+ git add -A
+ git commit -m 'Auto Format'
[add-OldestReplicationSlotLag 4209ba8] Auto Format
 12 files changed, 180 insertions(+), 24 deletions(-)
 create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml
 create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml
+ [[ dazza-codes == \c\l\o\u\d\p\o\s\s\e\b\o\t ]]
+ git push
To https://github.com/dazza-codes/terraform-aws-rds-cloudwatch-sns-alarms
 ! [remote rejected] add-OldestReplicationSlotLag -> add-OldestReplicationSlotLag (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/auto-context.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/dazza-codes/terraform-aws-rds-cloudwatch-sns-alarms'
Error: Process completed with exit code 1.

I don't know what it is trying to auto-format, since my version of terraform doesn't detect any format changes required.

@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support OldestReplicationSlotLag on PostgreSQL
3 participants
@dazza-codes @hans-d @mgeist