fix: Adds flex-wrap to the property filter header #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangevolon
commented
Oct 17, 2024
| @@ -15,6 +15,8 @@ $operator-field-width: 120px; | |||
| .search-field { | |||
| display: flex; | |||
| align-items: flex-end; | |||
| flex-wrap: wrap; | |||
| gap: awsui.$space-xs awsui.$space-s; | |||
There was a problem hiding this comment.
- Row spacing: For the vertical spacing when items are wrapped.
- Column spacing: Replacing the
margin-inline-endin line179
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2888 +/- ##
========================================
Coverage 96.20% 96.20%
========================================
Files 761 761
Lines 21447 21447
Branches 6940 7329 +389
========================================
Hits 20633 20633
Misses 806 806
Partials 8 8 ☔ View full report in Codecov by Sentry. |
pan-kot
approved these changes
Oct 17, 2024
orangevolon
deleted the
alamiami/fix-overflowing-content-in-small-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the property filter component overflowing its container in small screens.
Related links, issue #, if available: AWSUI-59283
How has this been tested?
Visual tests dev pipeline.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.