Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video preview shows a wrong frame for ordered chapters in multiple Editions #1896

Open
hubblec4 opened this issue Nov 5, 2022 · 1 comment
Labels
low priority PatchRequired Idea approved / bug confirmed. Now we just need someone to implement it...

Comments

@hubblec4
Copy link

hubblec4 commented Nov 5, 2022

Hi clsid

Wrong Video Preview.zip

Steps to reproduce the issue:

  1. Start the mkv
  2. Change the edition from Edition 1 to Edition 2 (I use the menu from the LAV TrayIcon)
  3. [*1] Move the mouse over the timeline and make a left click to jump to this timestamp

[*1]
You can pause playback for a better control to see which preview frame is used and what a frame is shown after the jump to this timestamp.

When you change the edition back to Edition 1 the video preview is fine again.

It is also possible to change the default edition.
-> set the Edition 2 as default edition and this edition uses the correct preview frames.
But after a change to Edition 1 the video preview don't work.

@clsid2
Copy link
Owner

clsid2 commented Nov 5, 2022

Preview uses a separate graph (with default edition) and isn't aware of any edition changes in the primary graph.

Note to self. To fix this:
LAV Splitter uses group value 18 for IAMStreamSelect. Use this info to change selected edition in preview graph if needed. Do this when EC_LENGTH_CHANGED event occurs.

@clsid2 clsid2 added PatchRequired Idea approved / bug confirmed. Now we just need someone to implement it... low priority labels Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority PatchRequired Idea approved / bug confirmed. Now we just need someone to implement it...
Projects
None yet
Development

No branches or pull requests

2 participants