-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Reorganizing Output Page #2453
Comments
Not related to this |
No, because advanced settings currently has advantage of showing tooltips with crucial information. Plus those settings are already grouped together. |
Putting video and audio next to each other doesn't look like an improvement to me. Those video renderer capability checkboxes should stay inside the video box to avoid more confusion. Moving libass option here is ok. Although I think the SRT option should maybe be moved to advanced options, as that is not something that the average user should be (tempted) to enable by default. VMR/EVR settings could be hidden when another renderer is selected. |
Is there any point in the 5 green checkmarks? |
Some renderers do not support all of those features. |
Right. Are there any that don't support subtitles or rotation, for example? |
Yes, for example vanilla EVR and VMR9 Windowed and VMR7. |
OK, sounds good. I don't like where they sit on the new layout as they are video renderer specific, right? There's also an issue with the checkmark assets that they look worse at higher res. Perhaps an info popup is more useful. Screenshot and subtitles are checked for all renderers except for the "null" ones (I see that it can also get unchecked if you choose a bad subtitle renderer). |
We could put a textfield below the dropdown to show a note whenever a "bad" renderer is currently selected. As replacement for the checkmarks. Something like "Note: the current selected video renderer does not support all advanced playback functionality." And tooltip of each selected renderer could show a bit more details then it currently does. |
I have a suggestion: And if there is enough empty space, you can move misc page items in output page. Edit: Another feature is HDR capabilities. That can be added. |
Taken some ideas from here for this patch. |
Edited unnecessary parts, layout may not be divided by half its just preference. Added some archaic representor of indicator if it is liked it can be changed by some svg samples.
Tooltips or balloons might be applied on relative groupbox hover or any desired place. libass renderer for text based subtitles (subrip) may be placed to advanced options or Right click option like Show percentage on Timer with some warning like "string...(not recommended)". IDD_PPAGEOUTPUT DIALOGEX 0, 0, 355, 289
STYLE DS_SETFONT | WS_CHILD
FONT 9, "Segoe UI", 400, 0, 0x1
BEGIN
GROUPBOX "DirectShow Video",IDC_STATIC,6,6,169,34
COMBOBOX IDC_VIDRND_COMBO,28,19,114,30,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
PUSHBUTTON "⛭",IDC_BUTTON1,148,18,21,13
GROUPBOX "Audio Renderer",IDC_STATIC,181,6,169,34
COMBOBOX IDC_AUDRND_COMBO,203,19,114,46,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
PUSHBUTTON "⛭",IDC_BUTTON2,323,18,21,13
GROUPBOX "Subtitle Renderer",IDC_STATIC,6,48,344,33
COMBOBOX IDC_COMBO1,28,61,114,46,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
CONTROL "Use libass renderer",IDC_CHECK2,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,185,62,158,10
GROUPBOX "VMR-9 (renderless) and EVR (CP) settings",IDC_STATIC,6,212,343,72
CONTROL "Select D3D9 Render Device",IDC_D3D9DEVICE,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,12,228,160,8
COMBOBOX IDC_D3D9DEVICE_COMBO,181,226,158,30,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
CONTROL "Reinitialize when changing display",IDC_RESETDEVICE,
"Button",BS_AUTOCHECKBOX | BS_MULTILINE | WS_TABSTOP,12,241,195,8
CONTROL "Cache compiled Shaders",IDC_CACHESHADERS,"Button",BS_AUTOCHECKBOX | BS_MULTILINE | WS_TABSTOP,12,254,195,8
CONTROL "Alternative VSync",IDC_DSVMR9ALTERNATIVEVSYNC,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,210,241,130,8
CONTROL "D3D Fullscreen",IDC_FULLSCREEN_MONITOR_CHECK,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,210,254,130,8
LTEXT "Resizer:",IDC_STATIC,10,269,70,8
COMBOBOX IDC_DX9RESIZER_COMBO,84,267,126,49,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
LTEXT "🟢",IDC_STATIC,10,21,12,8
LTEXT "🔻",IDC_STATIC,185,21,12,8
LTEXT "✔",IDC_STATIC,10,63,12,8
END |
Decoders do not belong on renderers page. |
Output page is getting older as far as player. Some settings takes unnecessary space (
VMR-9 (renderless) and EVR (CP) settings
), some supported abilities indicators lack of nowadays technologies like HDR, Pitch correction and others.My suggestions:
Options > Subtitles > Default Style
toOptions > Output > Subtitle renderer
block.extra
5. Move VMR-9 (renderless) and EVR (CP) settings and Sync Renderer Settings to seperate window like Mpc-Vr has, so people can easily access these only when needed.
I tried to demonstrate how I imagine output page
I only modificated mpc-hc.rc file and these are template codes for incase people are interested.
The text was updated successfully, but these errors were encountered: