-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.2 deprecation #35
Comments
Hey @bartvanhoutte, good catch 👍 I think we can go a similar as @clue did in reactphp/http#459. As you said, it involves some work but seems to be the best way. I don't know when exactly we will get to implement this as we're currently working a lot on ReactPHP and the upcoming v3, but we also don't want to push this too far back because PHP 8.2 has already been released. If you want to give it a try we're always happy about PRs! 😉 |
Closed via #43 @bartvanhoutte Thank you for reporting and the sparking this development with your initial PR! 👍 |
@clue 👍 Didn't follow up because I don't know how to squash commits or something like that 😅 |
@bartvanhoutte Don't worry, we're happy to help if you run into something like this next time. 👍 |
👋 Just discovered a deprecation using mq-react running on PHP 8.2.
Creation of dynamic property React\Promise\Deferred::$pending is deprecated in /var/www/vendor/clue/mq-react/src/Queue.php on line 432
Couple of ways to solve this:
#[AllowDynamicProperties]
in reactphp/promise v2 branch. Fast but might not be what we want.Queue
. Quite a bit of work but clean.What do you think?
The text was updated successfully, but these errors were encountered: