Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiplication factor #6

Open
marouenbg opened this issue Apr 24, 2019 · 3 comments
Open

multiplication factor #6

marouenbg opened this issue Apr 24, 2019 · 3 comments

Comments

@marouenbg
Copy link

Why are the weights multiplied by 0.5 in the modz calculation?

wt = 0.5*sum(cc, 2);

@weizhiting
Copy link

all weights are normalized and should sum to 1. so weights should multiplied by .5 for example:
three replicates: a b and c. and the correlation are Sab, Sac, Sbc. so the weights before normalized will be Sab + Sac, Sab + Sbc, Sac + Sbc for a, b and c, respectively. After normalized weights will be
(Sab + Sac) / 2(Sab + Sac + Sbc) for a.....

@marouenbg
Copy link
Author

marouenbg commented Jul 4, 2019

makes sense, but it shouldn't be hard coded in case there are less than three replicates.
should be 1/(size(cc, 2)-1)

@marouenbg
Copy link
Author

marouenbg commented May 8, 2020

nope the 0.5 is completely useless, you would get the same results if you remove it.
For example to compute the weight of a replicate A (and AB is the correlation between replicate A and B) you would get (according to the code)
weightA=0.5(AB+AC)/(0.5(|AB+AC|+|AB+BC|+|AC+BC|)), 0.5 then cancels out and the (absolute?) weight of the three replicates sums to one as expected.
I think the numerator was left signed for QC purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants