Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add aarch64 binary to releases #560

Open
life00 opened this issue Sep 5, 2024 · 7 comments
Open

Please add aarch64 binary to releases #560

life00 opened this issue Sep 5, 2024 · 7 comments
Labels
binaries github_actions Pull requests that update GitHub Actions code Help-wanted I'd like assistance with this issue, please!

Comments

@life00
Copy link

life00 commented Sep 5, 2024

Please add aarch64 linux binary to releases. Thanks :D

@cmhughes
Copy link
Owner

cmhughes commented Sep 5, 2024

It's controlled by github actions

https://github.com/cmhughes/latexindent.pl/blob/main/.github/workflows/build-documentation-and-executables.yaml

If you can help with this, please submit a pull request.

@cmhughes cmhughes added github_actions Pull requests that update GitHub Actions code Help-wanted I'd like assistance with this issue, please! binaries labels Sep 5, 2024
@life00
Copy link
Author

life00 commented Sep 6, 2024

After researching a bit I would say it might not be possible. The thing is that pp does not seem to support target architecture compilation. i.e. it's not possible to compile a binary for aarch64 from an x86_64 linux system. Btw before this I didn't even know that its possible to compile perl.

If you look at the man page of pp there is an option -m that supposedly produces multi-arch something, but I guess it produces the code in a packaged format for multiple architectures and it should be installed by the pp package manager afterwards. So its not very helpful.

I also looked at github actions and available architectures. So it seems that they do not offer any straightforward way of running on arm64: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners

I will probably open an issue on regarding this on https://github.com/rschupp/PAR-Packer, and maybe there is some undocumented environment variable that could be set to get targer architecture compilation working.

Edit: rschupp/PAR-Packer#91

@life00
Copy link
Author

life00 commented Sep 6, 2024

The maintainer responded: rschupp/PAR-Packer#91 (comment)

So yeah its not really possible it seems, unless github actions has aarch64/arm64 architecture linux machines.

@life00
Copy link
Author

life00 commented Sep 6, 2024

What a coincidence. It seems github released arm64 runners for linux just few days ago. I found a long thread about this here: https://github.com/orgs/community/discussions/19197

Relevant blog: https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/

@cmhughes I believe it would be enough to create a duplicate build-linux-executable, except maybe with an -arm64 suffix, and then change the runner to an arm64 one. I am sorry I have never used github actions so I have no idea how to configure or test it. They seem to have officially released windows and linux arm64 runners but I can't find any names for them. Maybe you'll have more luck with that blog above.

Edit: it seems to only be available to limited users of github:

These runners are available to our customers on our GitHub Team and Enterprise Cloud plans. We expect to begin offering Arm runners for open source projects by the end of the year.

I guess lets wait till the end of the year.

@cmhughes
Copy link
Owner

cmhughes commented Sep 6, 2024

Thanks for your time on this.

I believe it would be enough to create a duplicate build-linux-executable, except maybe with an -arm64 suffix, and then change the runner to an arm64 one

Yes, perfect, that's what I would like in the yaml file.

I guess we wait until it's available. Happy to leave this open, or close it at your preference.

@life00
Copy link
Author

life00 commented Dec 28, 2024

github/roadmap#970 still waiting... I guess it will be there somewhere in 2025 Q1.

@cmhughes
Copy link
Owner

great, thanks, let me know when you have an update. pull requests welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binaries github_actions Pull requests that update GitHub Actions code Help-wanted I'd like assistance with this issue, please!
Projects
None yet
Development

No branches or pull requests

2 participants