Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackBuilder should not write BRAM memory #277

Open
tomalin opened this issue May 14, 2024 · 0 comments
Open

TrackBuilder should not write BRAM memory #277

tomalin opened this issue May 14, 2024 · 0 comments

Comments

@tomalin
Copy link
Collaborator

tomalin commented May 14, 2024

The TrackBuilder (implemented in https://github.com/cms-L1TK/cmssw/blob/L1TK-dev-14_0_0_pre2/L1Trigger/TrackFindingTracklet/interface/FitTrack.h ) has output streams streamTrackRaw & stubStream, corresponding to the streams in FW. It also produces a historic copy of this output which it writes to memory TrackFitMemory. This does not correspond to the FW, where there is no BRAM memory after the TrackBuilder, so all references to the TrackFitMemory should be deleted. (Or better, disabled, so they can still be used with the historic pure "Tracklet" L1 track algorithm).
To allow this to happen, the writing of txt files corresponding to the TrackBuilder output (for FW testing) should be done using the stream output (possibly from L1FPGAProducer, after it has been converted into an EDProduct) instead of the TrackFitMemory::writeTF() function.

The existing code is unnnecessary complicated, with the TrackBuilder produces two alternative outputs, only one of which corresponds to the FW. The TrackFitMemory is also incapable of representing any gaps in the data stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant