Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/unify match criteria in MC/MPdisks #283

Open
aryd opened this issue Jul 20, 2023 · 0 comments
Open

Simplify/unify match criteria in MC/MPdisks #283

aryd opened this issue Jul 20, 2023 · 0 comments

Comments

@aryd
Copy link
Contributor

aryd commented Jul 20, 2023

In reviewing PR #242 we realized that the cuts used to select matches in the disks uses a combination of cuts on phi and r*phi. This code should be simplified, but this requires also changing the code in the emulation. We decided not to address this as part of this PR, but we entered this as an issue that we should track.

@pwittich pwittich mentioned this issue Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant