Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on additional performance advice in CMSSW PR 31722 #614

Open
ericcano opened this issue Apr 9, 2021 · 2 comments
Open

Follow up on additional performance advice in CMSSW PR 31722 #614

ericcano opened this issue Apr 9, 2021 · 2 comments

Comments

@ericcano
Copy link

ericcano commented Apr 9, 2021 •
edited
Loading

CMSSW PR 31722 Patatrack integration - Pixel track reconstruction (10/N) was merged with extra comments to be addressed.

This issue will address the performance related comments comments.
@ericcano ericcano changed the title Follow up on additional advice in CMSSW PR 31722 Follow up on additional performance advice in CMSSW PR 31722 Apr 15, 2021
ericcano added a commit to ericcano/cmssw that referenced this issue Apr 16, 2021
@ericcano
Reduced duplicate computations with temporary variables. (cms-patatra…
67466f6 
…ck#614)

Also removed addition of transposed matrix by directly copying the needed elements.
cms-sw#31722 (comment)
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this issue Apr 16, 2021
@ericcano
Minor simplification (cms-patatrack#614)
5dd4bb9 
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this issue Apr 16, 2021
@ericcano
Reduced computations with a local variable. (cms-patatrack#614)
b46cacf 
Also introduced a computation simplification suggested in:
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this issue Apr 16, 2021
@ericcano
Simplified computations. (cms-patatrack#614)
5e39a07 
cms-sw#31722 (comment)
cms-sw#31722 (comment)
cms-sw#31722 (comment)
ericcano added a commit to ericcano/cmssw that referenced this issue Apr 16, 2021
@ericcano
Removed unneeded range checking. (cms-patatrack#614)
661b456 
cms-sw#31722 (comment)
cms-sw#31722 (comment)
@ericcano
Copy link
Author

Implemented and validated in branch https://github.com/ericcano/cmssw/tree/cms-patatrack-cmssw-614-perf-IB-2021051711

@ericcano
Copy link
Author

Re validated against latest IB for CMSSW 12_0_X in https://github.com/ericcano/cmssw/tree/cms-patatrack-cmssw-614-perf-IB-2021052523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericcano