Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cudacompat layer to use a 1-dimensional grid #32586

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Simplify cudacompat layer to use a 1-dimensional grid #32586

merged 1 commit into from
Dec 26, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 26, 2020

PR description:

Remove the possibility of changing the grid size used by the cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.
This avoids a thread-related problem caused by TBB using worker threads where the grid size had not been initialised.

PR validation:

Changes in use in the Patatrack branch,

if this PR is a backport please specify the original PR and why you need to backport that PR:

These changes were originally integrated in cms-patatrack#586 .

@fwyzard
Simplify cudacompat layer to use a 1-dimensional grid
51f416d 
Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.

This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 26, 2020

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 26, 2020

+heterogeneous

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Dec 26, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32586/20586

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDAUtilities

can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2e962/11877/summary.html
CMSSW: CMSSW_11_3_X_2020-12-25-2300/slc7_amd64_gcc900

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c2e962/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c2e962/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d8b475f into cms-sw:master Dec 26, 2020
@fwyzard fwyzard deleted the patatrack_simplify_cudacompat branch December 27, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed heterogeneous-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_3_X
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @cmsbuild @silviodonato