You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Non-dataformat packages may only define transient data formats
For edm::Wrapper<T>, check that T has a class version set. This would need special treatment for standard types, so might not be worth it in the end.
Canceled (but useful to document here)
Version number should be updated only when checksum changes No, we've seen a few cases where it has been useful to update the class version without changing the class layout (checksum) in order to trigger io read rules
Non-template classes should have a class version set Can't easily require this, because we don't require versions for transient classes, and transient classes that are not edm::Wrapper<T> instantiations should not have persistent="false" set.
Checks in edmCheckClassVersion
Class template instantiations should not have a class version set
The text was updated successfully, but these errors were encountered:
Following up cms-sw/cmssw#45423 (comment)
Preparatory work
edmCheckClassVersion
#976Checks in
edmDumpClassVersion
+checkDictionaryUpdate.py
persistent=false
is allowed only foredm::Wrapper<T>
instantiations #983edm::Wrapper<T>
, check thatT
has a class version set. This would need special treatment for standard types, so might not be worth it in the end.Canceled (but useful to document here)
Version number should be updated only when checksum changesNo, we've seen a few cases where it has been useful to update the class version without changing the class layout (checksum) in order to trigger io read rulesNon-template classes should have a class version setCan't easily require this, because we don't require versions for transient classes, and transient classes that are notedm::Wrapper<T>
instantiations should not havepersistent="false"
set.Checks in
edmCheckClassVersion
The text was updated successfully, but these errors were encountered: