Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce policies on ROOT dictionaries #975

Open
7 of 11 tasks
makortel opened this issue Jul 31, 2024 · 0 comments
Open
7 of 11 tasks

Enforce policies on ROOT dictionaries #975

makortel opened this issue Jul 31, 2024 · 0 comments
Assignees
Labels

Comments

@makortel
Copy link
Collaborator

makortel commented Jul 31, 2024

Following up cms-sw/cmssw#45423 (comment)

Preparatory work

Checks in edmDumpClassVersion + checkDictionaryUpdate.py

Canceled (but useful to document here)

  • Version number should be updated only when checksum changes No, we've seen a few cases where it has been useful to update the class version without changing the class layout (checksum) in order to trigger io read rules
  • Non-template classes should have a class version set Can't easily require this, because we don't require versions for transient classes, and transient classes that are not edm::Wrapper<T> instantiations should not have persistent="false" set.

Checks in edmCheckClassVersion

  • Class template instantiations should not have a class version set
@makortel makortel self-assigned this Jul 31, 2024
@makortel makortel changed the title Enforce ROOT dictionary policies Enforce policies on ROOT dictionaries Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant