Fix unstructured logging variable formatting

[melange396]

We use a logger in a lot of places in this repo, which is good! To make this structured logging as useful as it can be, the event argument (usually the first unnamed arg) should be a static string (to filter more easily), and each dynamic/varying value should be specified in an individual named argument to the logger call. Much of the logging usage here follows those rules, but not all -- among other reasons, i think a lot came from when we ported to more proper logging from dumb print() statements that had variables inserted mid-string and we didnt fix the format.

As of right now, these are the files that seem to have the less-desired usage:

• covidcast-indicators/quidel_covidtest/delphi_quidel_covidtest/pull.py

  Line 59 in 2184da7

  logger.info(f"Pulling data received on {search_date.date()}")

• covidcast-indicators/changehc/delphi_changehc/update_sensor.py

  Line 44 in 2184da7

  logger.info("========= WARNING: WRITING SEs TO {0} =========".format(out_name))

• covidcast-indicators/_delphi_utils_python/delphi_utils/runner.py

  Line 63 in 2184da7

  logger.info(f"Started {ind_name} with covidcast-indicators version {current_version}")

• covidcast-indicators/google_symptoms/delphi_google_symptoms/patch.py

  Line 61 in 2184da7

  logger.info(f"""Start patching {params["patch"]["patch_dir"]}""")

• covidcast-indicators/claims_hosp/delphi_claims_hosp/modify_claims_drops.py

  Line 60 in 2184da7

  logger.info(f"Wrote {out_path}")

• covidcast-indicators/google_symptoms/delphi_google_symptoms/run.py

  Line 99 in 2184da7

  logger.info("No data for %s_%s_%s", geo_res, metric.lower(), sensor_name)

• covidcast-indicators/doctor_visits/delphi_doctor_visits/update_sensor.py

  Line 37 in 2184da7

  logger.info(f"========= WARNING: WRITING SEs TO {out_name} =========")

• covidcast-indicators/_delphi_utils_python/delphi_utils/export.py

  Lines 24 to 26 in 2184da7

  	logger.info(
  	"Filtering contradictory missing code in " +
  	"{0}_{1}_{2}.".format(sensor, metric, date.strftime(format="%Y-%m-%d"))

• covidcast-indicators/doctor_visits/delphi_doctor_visits/modify_claims_drops.py

  Line 51 in 2184da7

  logger.info(f"Wrote {out_path}")

• covidcast-indicators/doctor_visits/delphi_doctor_visits/patch.py

  Line 48 in 2184da7

  logger.info(f"""Start patching {params["patch"]["patch_dir"]}""")

• covidcast-indicators/doctor_visits/delphi_doctor_visits/run.py

  Line 91 in 2184da7

  logger.info("drop date:\t\t%s", dropdate)

• covidcast-indicators/_delphi_utils_python/delphi_utils/flash_eval/eval_day.py

  Lines 156 to 157 in 2184da7

  	name = f"Signal: {signal} Lag: {lag}"
  	logger.info(name, payload=p_text)

[aysim319]

Ah I didn't know that! Do we have a space/documentation/reference for best practices like these?

[aysim319]

#2029 (review)

Note: need to comeback once #1268 is finished