Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid classifier string breaks delphi_utils PyPI upload #2054

Closed
melange396 opened this issue Sep 12, 2024 · 1 comment · Fixed by #2055
Closed

Invalid classifier string breaks delphi_utils PyPI upload #2054

melange396 opened this issue Sep 12, 2024 · 1 comment · Fixed by #2055
Labels
bug Something isn't working release-blocking If this is not fixed by feature freeze time, kick this feature out of the release.

Comments

@melange396
Copy link
Contributor

Between

and

...we got a failure in the GH action that publishes the delphi_utils package, saying: "'License :: MIT' is not a valid classifier."

The accepted version of this would be License :: OSI Approved :: MIT License according to https://pypi.org/classifiers/. The other classifier strings we use appear to be valid.

Fix it in

and

@melange396 melange396 added bug Something isn't working release-blocking If this is not fixed by feature freeze time, kick this feature out of the release. labels Sep 12, 2024
@dshemetov
Copy link
Contributor

For future reference, validate-pyproject could help catch issues like this in the future:

$ uv tool install 'validate-pyproject[all]'
Resolved 4 packages in 134ms
Prepared 3 packages in 49ms
Installed 4 packages in 5ms
 + fastjsonschema==2.20.0
 + packaging==24.1
 + trove-classifiers==2024.9.12
 + validate-pyproject==0.19
Installed 1 executable: validate-pyproject

# Running on _delphi_utils
$ uv tool run validate-pyproject pyproject.toml 
Invalid file: pyproject.toml
[ERROR] `project.classifiers[3]` must be trove-classifier

# After fix
$ uv tool run validate-pyproject pyproject.toml
Valid file: pyproject.toml

@minhkhul minhkhul linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-blocking If this is not fixed by feature freeze time, kick this feature out of the release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants