Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in download script #11

Open
leighbmetcalf opened this issue Apr 5, 2024 · 4 comments · May be fixed by #12
Open

Error in download script #11

leighbmetcalf opened this issue Apr 5, 2024 · 4 comments · May be fixed by #12

Comments

@leighbmetcalf
Copy link

When I attempt to run download_signals.R I get

Error: honest_as_of should be set if and only if as_of is not set. Either remove as_of specification or set honest_as_of to FALSE. I attempted to set honest_as_of = FALSE but wasn't sure where it went to make this code work.

@capnrefsmmat
Copy link
Collaborator

@dshemetov It looks like this error comes from get_predictions() in evalcast, which is being called from download_signals.R. It looks like you added this argument a while back. Any recommendation on how to change the call to get the right result?

@dshemetov
Copy link

Taking a look, will get back to you later today.

@dshemetov
Copy link

dshemetov commented Apr 5, 2024

Alright, I think I've fixed it appropriately. Try using the branch in #12 and see if that works for you. The way as_of is handled in evalcast::get_predictions has changed somewhat since the code in this repo, but hopefully the results for this paper can still be reproduced. Let me know if you encounter further errors or discrepancies.

@leighbmetcalf
Copy link
Author

Hi, it's working for me now. Well, not exactly, I have a new error but it's a local problem that has nothing to do with your code. Thanks for getting back to me so quickly, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants