Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async_epidata calls from Epidata and the covidcast Python client #1298

Open
dshemetov opened this issue Oct 5, 2023 · 1 comment
Open
Labels
code health readability, maintainability, best practices, etc python client changes the Python client user experience things that affect users of our software or services

Comments

@dshemetov
Copy link
Contributor

dshemetov commented Oct 5, 2023

See @melange396's comment here for the reasoning behind deprecating this method. After that set of PRs is merged, async_epidata will be deprecated.

This issue is here to track the work of eventually removing this code from both delphi_epidata and from the covidcast Python client. The code in question:

  • in the covidcast client here
  • in the delphi_epidata client here
@melange396 melange396 added python client changes the Python client code health readability, maintainability, best practices, etc user experience things that affect users of our software or services labels Oct 11, 2023
@melange396
Copy link
Collaborator

SirCAL uses the async functionality and may incur a performance hit when it is removed (it will make its 14 single-day requests sequentially instead of simultaneously). related issue: cmu-delphi/covidcast-indicators#1931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health readability, maintainability, best practices, etc python client changes the Python client user experience things that affect users of our software or services
Projects
None yet
Development

No branches or pull requests

2 participants