Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Google Health Trends and Google Symptoms inactive/active marking #1538

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Aug 29, 2024

Summary:

Mark Google Health Trends as inactive. Rename Google symptoms page. Make all headers have the same format (nav_order in the same place).

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Copy link

sonarcloud bot commented Aug 29, 2024

@nmdefries nmdefries changed the title Ndefries/menu cleanup Switch Google Health Trends and Google Symptoms inactive/active marking Aug 29, 2024
@nmdefries
Copy link
Contributor Author

nmdefries commented Aug 29, 2024

The Covidcast data source pages are no longer ordered alphabetically. Nothing we changed here or in #1500 should have changed that (everything at the same nav order is sorted automatically) so the behavior should match that in production. Maybe this is a local issue? It's not intrusive, so will look into this later if it continues to be a problem.

@nmdefries
Copy link
Contributor Author

Ah, apparently "The order of pages with equal nav_order parameters is unstable: it may change with each build" (theme docs).

@nmdefries
Copy link
Contributor Author

I'll work on alphabetization in another PR, so this is ready to review, @tinatownes.

Copy link
Collaborator

@tinatownes tinatownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good. I'll see "Alphabetize reordered data source menu #1539" for alphabetization edits. Thanks!

@nmdefries nmdefries merged commit 7ef8a34 into dev Sep 9, 2024
7 checks passed
@nmdefries nmdefries deleted the ndefries/menu-cleanup branch September 9, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants