Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_target_date isn't supported for multiple aheads #344

Open
dsweber2 opened this issue Jun 24, 2024 · 0 comments
Open

add_target_date isn't supported for multiple aheads #344

dsweber2 opened this issue Jun 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dsweber2
Copy link
Contributor

This is somewhat an issue for smooth_quantile_reg, which has multiple target dates/aheads. Specifically in layer_add_target_date, though likely we would also need to modify pivot_quantiles_wider to also pivot the target_date if needed.

Snippet that goes ~50% of the way to solving this when replacing the end of slather.layer_add_target_date

if (length(target_date)>1) {
  target_date = list(target_date)
}
object$target_date <- list(target_date)
components$predictions <- components$predictions %>%
  mutate(target_date = list(target_date))

@dsweber2 dsweber2 added the enhancement New feature or request label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant