Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Slide" vignette reference to and conclusions about Texas reporting need to be expanded #367

Closed
nmdefries opened this issue Oct 26, 2023 · 1 comment · Fixed by #538
Closed
Assignees

Comments

@nmdefries
Copy link
Contributor

nmdefries commented Oct 26, 2023

The "slide a computation" vignette says “As we can see from the top right panel, it looks like Texas moved to weekly reporting of COVID-19 cases in summer of 2021.”

Texas is in the bottom right panel instead of the top right.

Some possible causes: the move from covidcast -> epidatr changed classes somehow, the API response's row ordering changed due to internals or to revisions, or there were updates to dplyr. We may want to check how this changed to make sure it doesn't shift underneath us again, or make the wording not mention plot location.

And how can we draw this kind of conclusion? This needs more explanation. GA has roughly the same curve as TX, can we also conclude that GA moved to weekly reporting?

I think this is from looking at the bars behind the lines. They aren't very visible right now; maybe we need to widen the plot and move to ggplotly to allow interactivity. We should check whether this conclusion is actually true, in addition to explaining and addressing GA (and FL?).

@nmdefries nmdefries changed the title "Slide" article reference to and conclusions about Texas reporting are confusion/need to be expanded "Slide" vignette reference to and conclusions about Texas reporting are confusion/need to be expanded Oct 26, 2023
@nmdefries nmdefries changed the title "Slide" vignette reference to and conclusions about Texas reporting are confusion/need to be expanded "Slide" vignette reference to and conclusions about Texas reporting need to be expanded Oct 26, 2023
@dshemetov dshemetov self-assigned this Oct 15, 2024
@dshemetov
Copy link
Contributor

Comment two is out of dated, there's no more commentary on GA. Fixing the TX comment in #538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants