Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a rename of epi_slide / epix_slide #525

Open
1 task
dshemetov opened this issue Sep 20, 2024 · 0 comments
Open
1 task

Consider a rename of epi_slide / epix_slide #525

dshemetov opened this issue Sep 20, 2024 · 0 comments
Assignees

Comments

@dshemetov
Copy link
Contributor

  • consider a rename of epi_slide / epix_slide (but let's try not to get stuck here)

Originally posted by @dshemetov in #477 (comment)

Two reasons to consider a rename:

  • the details of the functionality has drifted for both functions, with them becoming more focused and specific; this may allow us to be more descriptive in a new name
  • their naming similarity was maintained because we saw them as the same slide operation but on two different time dimensions (time_value and version/issue) and this led to wanting to keep their interfaces (and defaults) similar; as we came to use these functions more, we discovered that the defaults for these should be different (e.g the sliding window needs to support different alignments and not have a default size in epi_slide, while only a right-aligned and Infinite window size makes sense in epix_slide) and that their use cases are different enough to eclipse the underlying conceptual similarity
@dshemetov dshemetov mentioned this issue Sep 20, 2024
4 tasks
@brookslogan brookslogan self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants