Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pkgdown.yaml #440

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix: update pkgdown.yaml #440

wants to merge 1 commit into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Apr 25, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

David's fix was merged into pkgdown and it was released (thank you @hadley)! r-lib/pkgdown#2406

So now we can remove the workaround in our CI.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

* David's fix was merged and released in pkgdown
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsweber2
Copy link
Contributor

dsweber2 commented Apr 25, 2024

@nmdefries it looks like the build breaks when trying to handle slide.Rmd when documenting epi_slide_mean. It thinks it isn't defined, for some strange reason This was apparently a me problem, nevermind

@dshemetov
Copy link
Contributor Author

dshemetov commented Apr 25, 2024

I tested this locally, unfortunately after submitting this PR, and it looks like will require more work upstream with pkgdown. Going to keep this open and update when fixed.

@brookslogan brookslogan marked this pull request as draft June 20, 2024 22:48
@brookslogan
Copy link
Contributor

Converted this to draft to prevent me from auto-merging before the changes mentioned above happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants