Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwing panics over the FFI is UB #5

Open
maddiemort opened this issue May 1, 2019 · 1 comment
Open

Throwing panics over the FFI is UB #5

maddiemort opened this issue May 1, 2019 · 1 comment
Milestone
0.2

Comments

@maddiemort
Copy link

I notice that in a few places within the playground-utils-ffi crate, calls to expect() are made, and within xi-ffi, several calls to assert!() are made.

As far as I understand, throwing panics over the FFI is UB, and I wanted to flag this to your attention; I would suggest these be replaced with some other method of indicating errors. I know that Mozilla's ffi-support crate provides utilities for helping with this, for example.
@cmyr
Copy link
Owner

cmyr commented May 1, 2019

Good issue, thanks. This is something I was happy to gloss over while this was prototype code, but should probably address if I'm shipping it.

@cmyr cmyr added this to the 0.2 milestone May 1, 2019
@cmyr cmyr mentioned this issue May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@cmyr @maddiemort