Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Should duffle run require a claim name on stateless actions? #830

Open
itowlson opened this issue Aug 7, 2019 · 2 comments
Open

Should duffle run require a claim name on stateless actions? #830

itowlson opened this issue Aug 7, 2019 · 2 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@itowlson
Copy link
Contributor

itowlson commented Aug 7, 2019

duffle run currently always requires a claim name (installation name).

However, the CNAB spec for the actions section (https://github.com/deislabs/cnab-spec/blob/master/101-bundle-json.md#custom-actions) says:

"stateless: The action does not act on a claim, and does not require credentials. This is useful for exposing dry-run actions, printing documentation, etc." (emphasis added)

Should the claim name be optional in duffle run if the action is stateless? For example, how should the user perform a "dry run" custom action if they have never installed the bundle?

@glyn
Copy link
Contributor

glyn commented Aug 12, 2019

Makes sense to me. Note that the spec also says:

Stateless actions can be invoked on a non-existing installation.

which I think is ambiguous. It could mean that an existing installation need not be supplied or that the installation name can be one that doesn't exist. I think the former makes more sense.

@jeremyrickard jeremyrickard added this to the Duffle 1.0 milestone Aug 12, 2019
@jeremyrickard jeremyrickard added the help wanted Extra attention is needed label Aug 12, 2019
@itowlson
Copy link
Contributor Author

I wonder if the spec is leaving open the possibility of a speculative "print a dry run of what would happen if I supplied this installation name" action. But I agree it seems confusing, and could make implementations more complicated.

I have raised issue cnabio/cnab-spec#252.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants