Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zulip support for message URI #386

Closed
jayvdb opened this issue Nov 26, 2017 · 2 comments
Closed

Add Zulip support for message URI #386

jayvdb opened this issue Nov 26, 2017 · 2 comments
Assignees
@jayvdb
Labels
backend/zulip upstream

Comments

@jayvdb
Copy link
Member

jayvdb commented Nov 26, 2017 •
edited
Loading

This is needed for file issue to record where the command was given
Opened by @jayvdb
@jayvdb jayvdb self-assigned this Nov 26, 2017
@jayvdb
Copy link
Member Author

jayvdb commented Nov 26, 2017

Rather than add it to utils, I've created an issue upstream zulip/errbot-backend-zulip#6, and sent a WIP-ish patch upstream zulip/errbot-backend-zulip#7 .
I suspect the Zulip backend cant easily build these URLs. At least some URL creation algorithms need to be added to the python-api-library.

c.f. #394

As this may take a while, #392 is the better solution for now.

@jayvdb
Copy link
Member Author

jayvdb commented Nov 29, 2017

Merged upstream

@jayvdb jayvdb closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
backend/zulip upstream
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb