Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the mentors page with 2019 people #777

Closed
abhishalya opened this issue May 3, 2020 · 12 comments · Fixed by #781
Closed

Update the mentors page with 2019 people #777

abhishalya opened this issue May 3, 2020 · 12 comments · Fixed by #781
Assignees

Comments

@abhishalya
Copy link
Member

We should update the page with 2019 mentors instead of 2018.

@faraz16iqbal
Copy link

Hi, is it possible for me to work on this update?

@abhishalya
Copy link
Member Author

Yes! Why not. Assigned

@faraz16iqbal
Copy link

Can you please guide me as to how to access the information?

@abhishalya
Copy link
Member Author

Wouldn't it be nice if you could figure it out ;)

@chttrjeankr
Copy link
Contributor

@faraz16iqbal, are you still working on this?

@abhishalya
Copy link
Member Author

@chttrjeankr Do you want to take up this issue?

@chttrjeankr
Copy link
Contributor

@chttrjeankr Do you want to take up this issue?

Sure! I'd have to go through the newcomers' procedure first. I can then start working on it.

@abhishalya
Copy link
Member Author

Assigned to @chttrjeankr due to inactivity of previous assignee.

@chttrjeankr
Copy link
Contributor

Thanks for assigning. 🚀

I think you mean this Mentors Page.

The trace led me to realize the resources/js/directives/mentors.js file fetches data from data/projects.liquid which in turn fetches data from site.projects.

And since the site already has projects listed, I don't understand why it isn't automatically updating. I'm a bit new to JS so maybe I'm missing something? Could you help @abhishalya?

@chttrjeankr
Copy link
Contributor

chttrjeankr commented May 30, 2020

Figured out what to change. Discussing an appropriate solution would be needed.

The current code makes a list of all mentors who are in a project that has a status of NOT completed.
I don't think we want that to happen. (though #491 says we do(?))

So we have multiple options for the mentors page:

  1. To list all mentors from all projects that are complete.
  2. To list ALL mentors disregarding the project's status.
  3. To list only mentors from GSoC19 of projects that are complete.
  4. To list mentors from all GSoC19 projects.
  5. To make a dynamic mentors page to have mentors of GSoC for the present year. (not very suitable as coala is not in GSoC every year) (this has been tried earlier mentors.html: Change mentor page year dynamically #709)

The choice would depend on what exactly do we want the Mentors page to portray. Waiting for your views on the above. @abhishalya

@abhishalya
Copy link
Member Author

abhishalya commented May 30, 2020

@chttrjeankr Right, good research around this. So we want to change the existing implementation a bit, what we need is to get all mentors for the completed projects in latest program year (right now its 2019). In other words we need to list all mentors for all official (completed) projects for the latest GSoC coala participated in.

Now this might be a bit tricky with the existing data, you can have a look at #729 for reference. You can checkout webservices https://gitlab.com/coala/landing and see doing this is better with or without webservices involved. (webserivices might not be in good shape right now)

@chttrjeankr
Copy link
Contributor

chttrjeankr commented May 30, 2020

So we want to change the existing implementation a bit, what we need is to get all mentors for the completed projects in latest program year (right now its 2019). In other words we need to list all mentors for all official (completed) projects for the latest GSoC coala participated in.

@abhishalya The best solution to this would be if each project has a date/year attached to it. We can then filter by year(latest program year), initiative(GSoC) and status(completeness) and get the required projects and their mentors.

Or, having the initiatives be different. Rather than using GSoC, we may introduce GSoC19 initiatives, and similarly for RGSoC and other annual programs too, to maintain uniformity. This would need some manual updating to the project structures (I'm not sure where site.projects is fetching data from)

Now this might be a bit tricky with the existing data, you can have a look at #729 for reference. You can checkout webservices https://gitlab.com/coala/landing and see doing this is better with or without webservices involved. (webserivices might not be in good shape right now)

As far as this is concerned, the way to fetch results in #729 doesn't seem to work anymore. And yeah, webservices are in a pretty bad shape right now, with the last commit over a year ago. So, maybe involving that wouldn't be the best idea.

chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 3, 2020
The commit marks most of the projects initiatives with a `GSoC<year>` 
replacing `GSoC`

Closes coala#777
chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 3, 2020
Replacing static text from 2018 to 2019

Closes: coala#777
chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 3, 2020
Mentors of *completed* projects from *GSoC19* will be filtered for the 
mentors page

Closes: coala#777
@chttrjeankr chttrjeankr mentioned this issue Jun 3, 2020
2 tasks
chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 27, 2020
The commit marks most of the projects initiatives with a `GSoC<year>` 
replacing `GSoC`

Closes coala#777
chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 27, 2020
Replacing static text from 2018 to 2019

Closes: coala#777
chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 27, 2020
Mentors of *completed* projects from *GSoC19* will be filtered for the 
mentors page

Closes: coala#777
chttrjeankr added a commit to chttrjeankr/projects that referenced this issue Jun 27, 2020
The commit marks most of the projects initiatives with a `GSoC<year>`
replacing `GSoC`

Closes coala#777

partials/tabs/mentors.html: Change page for GSoC 2019 mentors

Replacing static text from 2018 to 2019

Closes: coala#777

resources/js/directives/mentors.js: Update filtering condition

Mentors of *completed* projects from *GSoC19* will be filtered for the
mentors page

Closes: coala#777

_projects: Update GSoC projects initiatives

The commit marks most of the projects initiatives with a `GSoC<year>`
replacing `GSoC`

Closes coala#777

partials/tabs/mentors.html: Change page for GSoC 2019 mentors

Replacing static text from 2018 to 2019

Closes: coala#777

resources/js/directives/mentors.js: Update filtering condition

Mentors of *completed* projects from *GSoC19* will be filtered for the
mentors page

Closes: coala#777

resources/js/directives/mentors.js: change filtering condition

Mentors of any recent projects will be listed whether completed or not

Closes: coala#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants