Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few issues with Container create validation #1459

Open
skobyda opened this issue Oct 19, 2023 · 2 comments
Open

Few issues with Container create validation #1459

skobyda opened this issue Oct 19, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@skobyda
Copy link
Contributor

skobyda commented Oct 19, 2023

Copied from @garrett 's comment at #1354 (review)

  1. Trash can icon is misaligned when there are elements pushing it vertically.

image

But this can be handled in a follow-up.


  1. I get an error of file not found in the autocomplete widget, but not as a message. Is this intended?

Screenshot from 2023-10-18 09-26-12

image

@skobyda skobyda added the bug Something isn't working label Oct 19, 2023
@skobyda skobyda changed the title Fix few issues with Container create dialog Few issues with Container create validation Oct 19, 2023
@jelly
Copy link
Member

jelly commented Nov 10, 2023

When the Host path is invalid we don't add it as a Volume so this should be fixed and made into an error.

Currently the validation seems to be:

    switch (key) {
    case "hostPath":
        break;

So nothing happens. This functionality uses Cockpit's FileAutoComplete component which has no way to give back an error state, except when an error has happened it returns an empty string and set's it's own error state.

As you don't know the previous state, it's hard to determine if there was an issue.

without breaking the FileAutoComplete onChange API, by adding another callback argument we could do:

            this.props.onChange('');
            if (this.props.onError) {
              this.props.onError(error)
            };

What gives:

image

@jelly
Copy link
Member

jelly commented Nov 10, 2023

We also lack this validation in the create pod modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants