Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image optimization into the container & release notes script #610

Open
garrett opened this issue Mar 8, 2023 · 3 comments
Open

Add image optimization into the container & release notes script #610

garrett opened this issue Mar 8, 2023 · 3 comments
Assignees

Comments

@garrett
Copy link
Member

garrett commented Mar 8, 2023

We ideally use oxipng on all the images and sometimes even pngquant. It would be ideal to bake these tools into our container creation and have the release notes automatically run oxipng -D on the resulting images.

pngquant is great too, but it is lossy and would need to be run manually (or be a manual step that's checked). oxipng is not lossy (visually) and is safe to automate.

@garrett garrett self-assigned this Mar 8, 2023
@garrett
Copy link
Member Author

garrett commented Jun 28, 2023

  1. Add oxipng in the container.
  2. Run oxipng from the release notes script.

@garrett
Copy link
Member Author

garrett commented Jun 28, 2023

I think -D (deflate) is the new standard now, so oxipng itself without the -D is fine.

@garrett
Copy link
Member Author

garrett commented Jun 28, 2023

@jelly mentioned that the official container (which we use) is Debian 10, which means we probably have to jump through hoops instead of just installing the command. So we might even need to curl it down from GitHub's releases.

(Otherwise, we'd have to install cargo and a rust compilation stack and then build/install oxipng.)

We may also want to include pngquant in the container, but not run it by default, as it is lossy and can change things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant