Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page links do not work #17788

Closed
supakeen opened this issue Oct 4, 2022 · 2 comments
Closed

Update page links do not work #17788

supakeen opened this issue Oct 4, 2022 · 2 comments
Assignees
@jelly
Labels
bug

Comments

@supakeen
Copy link

supakeen commented Oct 4, 2022

Explain what happens

  1. Open update page.
  2. Find an update that has a link in its description.
  3. Click this link.
  4. "This content is blocked. Contact the site owner to fix the issue."

Likely due to not allowed to frame the external website.

Version of Cockpit

main

Where is the problem in Cockpit?

Software updates

Server operating system

Fedora

Server operating system version

Fedora 37

What browsers are you using?

Chrome

System log

No response
@supakeen supakeen added the bug label Oct 4, 2022
@jelly
Copy link
Member

jelly commented Oct 4, 2022 •
edited
Loading

PackageKit gives us an update_text which is marked as markdown and parsed using remarkable (nodejs module) and unlike our bug/cve links these do not get a target="_blank" or noopener attribute set.

remarkablehas no way to do this via their API so we have to extend their hooks as for example in jonschlinkert/remarkable#410

@jelly jelly self-assigned this Oct 4, 2022
@garrett
Copy link
Member

garrett commented Oct 4, 2022 •
edited
Loading

@jelly: Oh, we absolutely need a target and noopener on those links. ☹️

I'm glad you're working on it.

jelly added a commit to jelly/cockpit that referenced this issue Oct 11, 2022
@jelly
packagekit: apply our link attributes to markdown
eac491c 
For CVE and bug links we set target="_blank", noopener and noreferrer.
The shown description is parsed from markdown and no custom attributes
are applied, our remarkable module does not have a standard way to set
these.

Closes cockpit-project#17788
@jelly jelly closed this as completed in 1c52e44 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jelly jelly

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garrett @jelly @supakeen