Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rate Limiting for crdb_internal.pebble_metrics() #107881

Closed
raggar opened this issue Jul 31, 2023 · 0 comments
Closed

Add Rate Limiting for crdb_internal.pebble_metrics() #107881

raggar opened this issue Jul 31, 2023 · 0 comments
Assignees
@raggar
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@raggar
Copy link
Contributor

raggar commented Jul 31, 2023 •
edited by cockroach-jira-scripts
Loading

Currently the crdb_internal.pebble_metrics() introduced in this pr: #107743 uses iterators to count different key types, snapshot pinned keys etc. As a result, these calls should be "rate limited".

Jira issue: CRDB-30240
@raggar raggar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 31, 2023
@raggar raggar self-assigned this Jul 31, 2023
@blathers-crl blathers-crl bot added the T-storage Storage Team label Jul 31, 2023
@raggar raggar closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raggar raggar

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
Storage
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raggar