Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemachanger: support FastPathResults for zone configs #134428

Open
annrpom opened this issue Nov 6, 2024 · 0 comments
Open

schemachanger: support FastPathResults for zone configs #134428

annrpom opened this issue Nov 6, 2024 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@annrpom
Copy link
Contributor

annrpom commented Nov 6, 2024

In the legacy schema changer,

func (n *setZoneConfigNode) FastPathResults() (int, bool) { return n.run.numAffected, true }
is used to determine how many rows were affected for a CONFIGURE ZONE statement. In this case, we seem to just represent discard as 0 and any other write as 1. This issue tracks supporting something like this in the DSC

// We don't really care how many keys are affected since this function always
// write one single zone config.
if len(r.Keys) > 0 {
numAffected = 1
}

Jira issue: CRDB-44077

Epic CRDB-43532

@annrpom annrpom added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

1 participant