Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostics: add datadriven testing to diagnostics output to detect regressions/changes #134450

Open
dhartunian opened this issue Nov 6, 2024 · 2 comments
Open

diagnostics: add datadriven testing to diagnostics output to detect regressions/changes #134450

dhartunian opened this issue Nov 6, 2024 · 2 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-postmortem Originated from a Postmortem action item. P-1 Issues/test failures with a fix SLA of 1 month T-observability

Comments

@dhartunian
Copy link
Collaborator

dhartunian commented Nov 6, 2024 •
edited by cockroach-jira-scripts
Loading

Today, it's not possible to easily detect changes in the diagnostic output for a cluster.

What's been tricky here is managing the fact that the output of diagnostics is non-deterministic. We can probably filter the output lightly to make a deterministic payload for testing. This will likely have to be the sql and schema stats data which can contain arbitrary numbers.

Jira issue: CRDB-44083
@dhartunian dhartunian added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-postmortem Originated from a Postmortem action item. P-1 Issues/test failures with a fix SLA of 1 month T-observability labels Nov 6, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 6, 2024

Hi @dhartunian, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@dhartunian dhartunian removed the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 6, 2024
@exalate-issue-sync exalate-issue-sync bot added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 6, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 6, 2024

Hi @exalate-issue-sync[bot], please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-postmortem Originated from a Postmortem action item. P-1 Issues/test failures with a fix SLA of 1 month T-observability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dhartunian