From d788779e8851b13e0d0dfd0c32dc54a91555b2c4 Mon Sep 17 00:00:00 2001
From: Florence Morris <florence@cockroachlabs.com>
Date: Thu, 19 Dec 2024 11:51:51 -0500
Subject: [PATCH] DOC-11640 PR #134018 - settings: redact all string settings
 for diagnostics (#19243)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* In telemetry-table.html include file, updated to mention that string values of sensitive settings are redacted.

* Incorporated Kathryn’s feedback.
---
 src/current/_includes/common/telemetry-table.html | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/current/_includes/common/telemetry-table.html b/src/current/_includes/common/telemetry-table.html
index 557d766c574..7fb0bad4d11 100644
--- a/src/current/_includes/common/telemetry-table.html
+++ b/src/current/_includes/common/telemetry-table.html
@@ -83,9 +83,7 @@
  </tr>
  <tr>
   <td>Altered cluster settings</td>
-  <td>
-      Cluster settings that have been altered from their default values.
-      Note that any values of type 'string' are redacted, such as the cluster organization.
+  <td>Cluster settings that have been altered from their default values. Note that every value of type 'string' is redacted, such as the cluster organization, as well as sensitive settings, such as OIDC authentication.
   </td>
   <td>
    <ul>
@@ -96,8 +94,11 @@
   <td>
    <code>
 "alteredSettings": {
-    "cluster.organization": "\u003credacted\u003e", "kv.lease.expiration_leases_only.enabled": "false",
-    "kv.rangefeed.enabled": "true"
+    "cluster.organization": "\u003credacted\u003e",
+    "cluster.secret": "\u003credacted\u003e",
+    "kv.rangefeed.enabled": "true",
+    "server.oidc_authentication.client_id": "\u003credacted\u003e",
+    "server.oidc_authentication.client_secret": "\u003credacted\u003e",
   }
 </code>
   </td>