From ab9744f21a4a1bba2f128548b820af695e7e8b4e Mon Sep 17 00:00:00 2001 From: Ryan Kuo <8740013+taroface@users.noreply.github.com> Date: Fri, 29 Mar 2024 15:33:59 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Matt Linville (he/him) --- src/current/_includes/v23.2/misc/force-index-selection.md | 2 +- src/current/_includes/v23.2/sql/disallow-full-table-scans.md | 2 +- src/current/_includes/v23.2/sql/no-full-scan.md | 2 +- src/current/_includes/v23.2/sql/transactions-limit-rows.md | 2 +- src/current/_includes/v24.1/misc/force-index-selection.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/current/_includes/v23.2/misc/force-index-selection.md b/src/current/_includes/v23.2/misc/force-index-selection.md index 5dd8f046fb7..ef0d199dd1b 100644 --- a/src/current/_includes/v23.2/misc/force-index-selection.md +++ b/src/current/_includes/v23.2/misc/force-index-selection.md @@ -138,5 +138,5 @@ Time: 1ms total (execution 1ms / network 0ms) {% include {{ page.version.version }}/sql/no-full-scan.md %} {{site.data.alerts.callout_success}} -For other methods of preventing full scans, see [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans). +For other ways to prevent full table scans, refer to [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans). {{site.data.alerts.end}} \ No newline at end of file diff --git a/src/current/_includes/v23.2/sql/disallow-full-table-scans.md b/src/current/_includes/v23.2/sql/disallow-full-table-scans.md index b0f7905bc4e..57701770065 100644 --- a/src/current/_includes/v23.2/sql/disallow-full-table-scans.md +++ b/src/current/_includes/v23.2/sql/disallow-full-table-scans.md @@ -1,4 +1,4 @@ -- At the cluster level, set `disallow_full_table_scans` for some or all users/roles. For example: +- At the cluster level, set `disallow_full_table_scans` for some or all users and roles. For example: {% include_cached copy-clipboard.html %} ~~~ sql diff --git a/src/current/_includes/v23.2/sql/no-full-scan.md b/src/current/_includes/v23.2/sql/no-full-scan.md index 16423e4496c..304c2ab9697 100644 --- a/src/current/_includes/v23.2/sql/no-full-scan.md +++ b/src/current/_includes/v23.2/sql/no-full-scan.md @@ -12,4 +12,4 @@ SELECT * FROM table_name@{FORCE_INDEX=index_name,NO_FULL_SCAN} WHERE b > 0; ~~~ - This will force a constrained scan of the partial index. If a constrained scan of the partial index is not possible, an error will be returned. \ No newline at end of file + This forces a constrained scan of the partial index. If a constrained scan of the partial index is not possible, an error is returned. \ No newline at end of file diff --git a/src/current/_includes/v23.2/sql/transactions-limit-rows.md b/src/current/_includes/v23.2/sql/transactions-limit-rows.md index 20c51ded881..0962a211195 100644 --- a/src/current/_includes/v23.2/sql/transactions-limit-rows.md +++ b/src/current/_includes/v23.2/sql/transactions-limit-rows.md @@ -12,4 +12,4 @@ ALTER ROLE ALL SET transaction_rows_written_err = 1000; ~~~ -To assess the impact of enabling these settings, use the corresponding session settings [`transaction_rows_read_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-read-log) and [`transaction_rows_written_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-written-log) to log transactions that read or write the specified number of rows. Transactions are logged to the [`SQL_PERF`]({% link {{ page.version.version }}/logging.md %}#sql_perf) channel. \ No newline at end of file +To assess the impact of configuring these session settings, use the corresponding session settings [`transaction_rows_read_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-read-log) and [`transaction_rows_written_log`]({% link {{ page.version.version }}/set-vars.md %}#transaction-rows-written-log) to log transactions that read or write the specified number of rows. Transactions are logged to the [`SQL_PERF`]({% link {{ page.version.version }}/logging.md %}#sql_perf) channel. \ No newline at end of file diff --git a/src/current/_includes/v24.1/misc/force-index-selection.md b/src/current/_includes/v24.1/misc/force-index-selection.md index 5dd8f046fb7..beeb1bcceac 100644 --- a/src/current/_includes/v24.1/misc/force-index-selection.md +++ b/src/current/_includes/v24.1/misc/force-index-selection.md @@ -138,5 +138,5 @@ Time: 1ms total (execution 1ms / network 0ms) {% include {{ page.version.version }}/sql/no-full-scan.md %} {{site.data.alerts.callout_success}} -For other methods of preventing full scans, see [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans). +For other ways to prevent full scans, refer to [Prevent the optimizer from planning full scans]({% link {{ page.version.version }}/performance-best-practices-overview.md %}#prevent-the-optimizer-from-planning-full-scans). {{site.data.alerts.end}} \ No newline at end of file