Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingering global flags #914

Open
bobvawter opened this issue Jun 12, 2024 · 2 comments
Open

Lingering global flags #914

bobvawter opened this issue Jun 12, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@bobvawter
Copy link
Member

There are still some old flags declared as globals (schemawatch.RefreshDelay is one) that aren't wired up to the CLI commands. We should checks for any dangling flags and ensure they're registered.

@ryanluu12345
Copy link
Contributor

@bobvawter is the ask here to deprecate these and remove? Or to make sure we wire them up to the CLI?

@ryanluu12345 ryanluu12345 added the good first issue Good for newcomers label Oct 3, 2024
@bobvawter
Copy link
Member Author

Not all of the older packages currently define a configuration object (e.g. staging/stage). I think the work is really to ensure there's a consistent way to define configuration types and ensure that they're correctly wired up without creating a situation where irrelevant flags are exposed on the various CLI command objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants