Support inline enum and update rollup/terser version to latest. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
commented
Aug 12, 2024
| strDefines['Uint32Array.BYTES_PER_ELEMENT'] = '4'; | ||
| strDefines['Int8Array.BYTES_PER_ELEMENT'] = '1'; | ||
| strDefines['Int16Array.BYTES_PER_ELEMENT'] = '2'; | ||
| strDefines['Int32Array.BYTES_PER_ELEMENT'] = '4'; |
There was a problem hiding this comment.
Also inline BYTES_PER_ELEMENT
dumganhar
changed the title
dumganhar
commented
Aug 12, 2024
| keep_fnames: !doUglify, | ||
| mangle: { | ||
| properties: { | ||
| regex: /^[a-zA-Z_][a-zA-Z0-9_]{3,}\$$/, |
There was a problem hiding this comment.
Support minify properties of which name ends with $
minggo
approved these changes
Aug 12, 2024
dumganhar
added a commit
to dumganhar/cocos-engine
that referenced
this pull request
Aug 12, 2024
…s to reduce js size. Add WebGLConstants.ts for inlining enums. Depends on: cocos/cocos-ccbuild#65
6 tasks
dumganhar
added a commit
to dumganhar/cocos-engine
that referenced
this pull request
Sep 13, 2024
…s to reduce js size. Add WebGLConstants.ts for inlining enums. Depends on: cocos/cocos-ccbuild#65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.