Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize type PVData in particle system #15553

Closed
PPpro opened this issue Jun 27, 2023 · 0 comments
Closed

optimize type PVData in particle system #15553

PPpro opened this issue Jun 27, 2023 · 0 comments
Assignees
Milestone

Comments

@PPpro
Copy link
Contributor

PPpro commented Jun 27, 2023

In the implementation of the current particle system, the type of pvdata is very wierd. It is an array, but the type of the array element is uncertain, like below:

// TODO: we should not use this type, should use a uniform array type instead.
// Tracking issue: https://github.com/cocos/cocos-engine/issues/15553
export type PVData = [Vec3, Vec3, Vec3, Vec3, number, Vec3 | null, null];

it's not good for type system and AOT optimization, we should take a time to optimize this property type of _attrs

issue from PR: #15527

@PPpro PPpro changed the title optimize type PVData optimize type PVData in particle system Jun 27, 2023
@SantyWang SantyWang added this to the V3.8.1 milestone Jun 27, 2023
@zxx43 zxx43 closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants