Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #15781: Potential memory issue in StringUtil::format if argument size is greater than 4096 #15903

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

dumganhar
Copy link
Contributor

Re: #15781

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo August 9, 2023 06:47
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

1 similar comment
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@dumganhar, Please check the result of run test cases:

Task Details

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@dumganhar, Please check the result of run test cases:

Task Details

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

@sushanhong
Copy link
Contributor

@cocos-robot run test cases

@github-actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL compressWithGray compressWithGray
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL object-group-image,puzzle,shield-node,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL compressWithGray compressWithGray
android PASS PASS FAIL object-group-image,puzzle,shield-node,rich-text-long-string-truncation
mac PASS PASS PASS

@minggo minggo merged commit d6d3723 into cocos:develop Aug 14, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants