Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window title when executable name set & Refactor native-pack-tool/windows run logic #15523

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Jun 25, 2023

Re: #

Changelog

  • Bugfix: window title encoding error when using Chinese App name
  • Simplify run logic on windows build panel

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@PatriceJiang PatriceJiang added this to the V3.8.0 milestone Jun 25, 2023
@PatriceJiang
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@github-actions
Copy link

@PatriceJiang, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL Morph-Head,deprecated,rich-text-align,rich-text-long-string-truncation,mask-type-change,mask-use-image-stencil,sharedMaterial,rich-text,system-font
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL EasingMethods EasingMethods
android PASS PASS PASS
mac PASS PASS PASS

@PatriceJiang PatriceJiang requested a review from minggo June 25, 2023 09:38
@PatriceJiang PatriceJiang changed the base branch from v3.8.0 to v3.8.1 June 25, 2023 09:41
@minggo minggo merged commit f9d7a40 into cocos:v3.8.1 Jun 26, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants