Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimization] free string memory after JSON is parsed. #17479

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Aug 1, 2024

V8's garbage collector only take care of JS Heap and ignore the external string size. So ExternalStringResource::Dispose may be delayed which will cause memory in high value.

Re: #17012

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

Optimized memory management for external strings in JSON parsing by ensuring prompt memory release.

  • Modified native/cocos/bindings/jswrapper/v8/Utils.cpp to call delete this in ExternalStringResource::Dispose.
  • Removed atomic counter gExternalCount for tracking external strings.
  • Explicitly cleared and shrunk string memory post-parsing to reduce memory usage.
  • Adjusted native/cocos/bindings/jswrapper/v8/Object.cpp to align with new memory management logic.

V8's garbage collector only take care of JS Heap and ignore the external string size.  So  ExternalStringResource::Dispose may be delayed which will cause memory in high value.
@dumganhar dumganhar requested a review from minggo August 1, 2024 09:41
Copy link

github-actions bot commented Aug 1, 2024

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

github-actions bot commented Aug 1, 2024

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
ios FAIL FAIL
mac FAIL FAIL

Copy link

github-actions bot commented Aug 1, 2024

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows FAIL FAIL
android FAIL FAIL
wechatgame PASS FAIL FAIL

@dumganhar dumganhar merged commit 77d88d5 into cocos:v3.8.4 Aug 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants