-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimization] free string memory after JSON is parsed. #17479
Conversation
V8's garbage collector only take care of JS Heap and ignore the external string size. So ExternalStringResource::Dispose may be delayed which will cause memory in high value.
Interface Check ReportThis pull request does not change any public interfaces ! |
@cocos-robot run test cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@dumganhar, Please check the result of
Task Details
|
@dumganhar, Please check the result of
Task Details
|
V8's garbage collector only take care of JS Heap and ignore the external string size. So ExternalStringResource::Dispose may be delayed which will cause memory in high value.
Re: #17012
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
Optimized memory management for external strings in JSON parsing by ensuring prompt memory release.
native/cocos/bindings/jswrapper/v8/Utils.cpp
to calldelete this
inExternalStringResource::Dispose
.gExternalCount
for tracking external strings.native/cocos/bindings/jswrapper/v8/Object.cpp
to align with new memory management logic.